Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace code with new assertion #25

Open
jaredoconnell opened this issue Jan 25, 2024 · 0 comments
Open

Replace code with new assertion #25

jaredoconnell opened this issue Jan 25, 2024 · 0 comments

Comments

@jaredoconnell
Copy link
Contributor

jaredoconnell commented Jan 25, 2024

        var grammarErr *InvalidGrammarError
	ok := errors.As(err, &grammarErr)
	if !ok {
		t.Fatalf("Returned error is not InvalidGrammarError")
	}

It seems like it would good to refactor this into

	assert.ExpectedError(&grammarErr)

with the code moved to go-assert/error.go.

Originally posted by @webbnh in #23 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant