Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating carpenter build yaml template to reflect integration of Quay… #14

Merged
merged 2 commits into from
Nov 15, 2022
Merged

updating carpenter build yaml template to reflect integration of Quay… #14

merged 2 commits into from
Nov 15, 2022

Conversation

jdowni000
Copy link
Contributor

… Image Expiration LABELS for dev images

Attempting to split the Jobs of carpenter by branch. If the build is triggered on the main branch it will build as normal and push to quay with the latest tag and the integration of quay expiration time label will be set to the default of never.
If the build is triggered under any other branch for development. It will create the image with a tag of the branch and small hash, as well as setting the quay expiration label to 90 days to auto delete from the quay repository.

Please explain your changes here.


By contributing to this repository, I agree to the contribution guidelines.

@jdowni000
Copy link
Contributor Author

A note if someone is diving through the logs...The Quay Image Expiration LABEL will not be included in image until PR arcalot/arcaflow-container-toolkit#22 is merged. This PR in carpenter will allow this to be set in image build options

@jdowni000 jdowni000 marked this pull request as ready for review November 10, 2022 15:08
@jdowni000 jdowni000 self-assigned this Nov 10, 2022
@jdowni000 jdowni000 added the enhancement New feature or request label Nov 10, 2022
.github/workflows/carpenter_push.yaml Outdated Show resolved Hide resolved
.github/workflows/carpenter_push.yaml Show resolved Hide resolved
@portante
Copy link

Also, in general, you want to try to follow git commit message "rules".

@jdowni000
Copy link
Contributor Author

I wrote my last commit prior to seeing this message. I will utilize this information moving forward

@dustinblack dustinblack merged commit a984bf1 into arcalot:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants