Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AR-4522] Remove widget before login #117

Merged
merged 36 commits into from
Nov 4, 2022
Merged

[AR-4522] Remove widget before login #117

merged 36 commits into from
Nov 4, 2022

Conversation

makylfang
Copy link
Contributor

@makylfang makylfang commented Nov 3, 2022 •
edited

PR

Describe your changes

  • Widget to be not displayed pre login
  • Updated version
  • Added mistakenly removed build:ts to build script

Issue ticket number and link

Checklist before requesting a review

  • You have performed a self-review of your own code
  • You are using approved terminology
  • Your changes have been tested locally
  • Your code builds clean without any errors or warnings

makylfang and others added 30 commits August 24, 2022 09:33
@makylfang
Removed code related to handling processing of request
fe3094d
@makylfang
Merge branch 'dev' of https://github.com/arcana-network/auth into mak…
52c67ec 
…yl/AR-3992-phase-ii-changes
@makylfang
Initial commit for plug n play auth
04364c2
@makylfang
Added closeFunc to ModalParams, replaced useState with useReducer in …
31d0deb 
…modal.tsx, updated action component with method
@makylfang
dev pull and conflict resolution
dadada0
@makylfang
Fixed form button to prevent default routing, Added connect button in…
1ea9dce 
… examples, fixed twitter icon link, fixed login list for connect to be fetched
@makylfang
Added loader svg, added css variables
0912513
@makylfang
Moved theme to a different file, updated styles to be generated from …
36f0812 
…theme
@makylfang
Merge branch 'dev' of https://github.com/arcana-network/auth into mak…
3786b2d 
…yl/AR-4416-plug-n-play
@makylfang
Updated versions for babel-jest and jsdom
57a1da5
@makylfang
Fixed import in components.tsx for getTheme
567d78b
@makylfang
Merge branch 'dev' of https://github.com/arcana-network/auth into mak…
c7748b1 
…yl/AR-4416-plug-n-play
@makylfang
merged dev, updated classnames to have xar- prefix, updated closing m…
6635f2f 
…odal to throw error
@makylfang
resolved merge commits
9ec7aa0
@makylfang
Getting logo and theme from authprovider
9fdf66d
@makylfang
Added style.css for modal, added postcss and rollup module for it
209bc22
@makylfang
removed theme.ts, added stroke for loader in css file
ccca2dd
@makylfang
Merge branch 'dev' of https://github.com/arcana-network/auth into mak…
5b5c191 
…yl/AR-4416-plug-n-play
@shaloo
Hotfix: Refs: #AR-3986 usage guide
78d71a4
@shaloo
typo fix Update usage.md
e846d42
@shaloo
bug fix Update usage.md
7ac5074
@shaloo
Merge pull request #115 from arcana-network/shaloo/hotfix-AR-3986-usage
51a697f 
Hotfix: Refs: #AR-3986 usage guide
@makylfang
Updated example for connect
d468b32
@makylfang
Using fallback from utils
6871d19
@makylfang
Removed sourcemap generation
a24e8a9
@makylfang
Removed theme from ui/typings, imported from base/typings, removed ci…
922c216 
…rcular dependency bug
@makylfang
Updated build target to commonjs, removed a circular dependency bug
9e2f62c
@makylfang
Updated version
ac03942
@makylfang
Merge pull request #116 from arcana-network/makyl/hotfix-build-target
e9810d3 
[Hotfix] build target
@makylfang
Merge branch 'main' of https://github.com/arcana-network/auth into ma…
295d45d 
…kyl/AR-4416-plug-n-play
@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited

✅ Deploy Preview for dev-authsdk-ref-guide ready!

Name Link
🔨 Latest commit 351b3a8
🔍 Latest deploy log https://app.netlify.com/sites/dev-authsdk-ref-guide/deploys/6364af46955705000852c14d
😎 Deploy Preview https://deploy-preview-117--dev-authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited

✅ Deploy Preview for authsdk-ref-guide ready!

Name Link
🔨 Latest commit 351b3a8
🔍 Latest deploy log https://app.netlify.com/sites/authsdk-ref-guide/deploys/6364af46b52f210009e226f4
😎 Deploy Preview https://deploy-preview-117--authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@makylfang makylfang merged commit d488652 into dev Nov 4, 2022
@makylfang makylfang deleted the makyl/AR-4522-remove-widget-before-login branch November 4, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajithranka ajithranka ajithranka approved these changes

@karthik-durai karthik-durai Awaiting requested review from karthik-durai

@shrinathprabhu shrinathprabhu Awaiting requested review from shrinathprabhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makylfang @ajithranka @shaloo