Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AR-4622] Remove No-UI mode #118

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Conversation

makylfang
Copy link
Contributor

@makylfang makylfang commented Nov 7, 2022

PR

Describe your changes

  • Removed params from .init(), added to constructor params.
  • theme is taken as a constructor param now.
  • Removed NO-UI mode.
  • Added alwaysShowWidget flag to constructor params to choose between Full and Widget mode, defaults to Full mode.
  • Removed sentry dependency.
  • Removed rollup polyfill packages from dependencies since they are not used now.
  • Updated Error naming to be prefixed with Error... instead of postfix
  • Updated usage.md

Issue ticket number and link

Checklist before requesting a review

  • You have performed a self-review of your own code
  • You are using approved terminology
  • Your changes have been tested locally
  • Your code builds clean without any errors or warnings

…ui mode, widget or full mode chosen by alwaysShowWidget flag - defaults to true
@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for authsdk-ref-guide ready!

Name Link
🔨 Latest commit 03fa366
🔍 Latest deploy log https://app.netlify.com/sites/authsdk-ref-guide/deploys/6369ea77a1d95f000857d80d
😎 Deploy Preview https://deploy-preview-118--authsdk-ref-guide.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for dev-authsdk-ref-guide ready!

Name Link
🔨 Latest commit 03fa366
🔍 Latest deploy log https://app.netlify.com/sites/dev-authsdk-ref-guide/deploys/6369ea77da09d80008b11dac
😎 Deploy Preview https://deploy-preview-118--dev-authsdk-ref-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@makylfang makylfang merged commit 55ba944 into dev Nov 8, 2022
@makylfang makylfang deleted the makyl/AR-4622-remove-no-ui-mode branch November 8, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants