fix: use the browser field in the root package.json
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/fix/browser-field
branch
from
e1c6b9d
to
cc43519
Compare
|
Released as 4.0.0-rc.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
#120 caused
./lib/advanced/Cli.mjsto contain an unqualified import to theplatformfolder instead of the files in it.Fixes nodejs/corepack#349 (comment)
How did you fix it?
Import the
nodeplatform directly, remove thesources/platform/package.jsonfile, and add abrowserandmodulefield to thepublishConfig.This let's bundlers pick the
moduleversion and if they're bundling for a browser replace./lib/platform/node*with./lib/platform/browser*.