fix: Command.String options incorrectly inferred as string | boolean
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It wasn't too clear on how to represent the current issue in the test suite, but I have screenshots that at least shows the problem that this PR solves: with these changes: |
StringOptionNoBoolean is more specific than StringOptionTolerateBoolean and needs be listed first to correctly infer plain string types.
|
Thanks! I've added an inference test file to avoid problems like this in the future 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3 implementation, I think the overloads on
Command.Stringwere defined in the wrong order. It doesn't seem like it's possible to define an option with an initial value without Clipanion thinking the value is possibly aboolean.