Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deck Model #31

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Update Deck Model #31

merged 5 commits into from
Aug 1, 2023

Conversation

iambroadband
Copy link
Contributor

Issue #24

Description

We have a baseline Deck model now, but we need some of the following:

  1. Validation
    • We should be validating the incoming data. We need to make sure that when we use .add_card(Card), it maintains a valid state
    • We need to make sure that the default values for each field are valid and make sense
  2. Testing
    • We need to add tests for all of the functionality of a Deck model.
    • These tests should use a real decklist and not something that's just a few cards.
  3. Write tickets for follow-up steps
    • We will need to create database endpoints and routers for Deck objects in the database. Write tickets to implement those

@iambroadband iambroadband linked an issue Aug 1, 2023 that may be closed by this pull request
@iambroadband iambroadband merged commit 73903b6 into dev Aug 1, 2023
@iambroadband iambroadband deleted the update_deck_model branch August 1, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Deck Model
2 participants