Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting of a graph fails if one of the associated instances references a concept in the primary display that has been deleted #5957

Closed
apeters opened this issue Mar 4, 2020 · 4 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@apeters
Copy link
Member

apeters commented Mar 4, 2020

if a user deletes a concept that is referenced in a primary display for a resource, then deleting that resource throws an error (and so does deleting the associated graph).

this is caused by not appropriately handling for when the 'get' method throws a DoesNotExist errr on this line:
https://github.com/archesproject/arches/blob/5.0.0/arches/app/datatypes/concept_types.py#L32

see this thread for a stack trace:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/archesproject/XX26MV55LUo/d2Cv1OTZAgAJ

@apeters apeters added the Type: Bug Something isn't working label Mar 4, 2020
@whatisgalen whatisgalen self-assigned this Mar 16, 2020
@whatisgalen
Copy link
Member

Unable to reproduce: Unable to delete a concept in RMD manager that is being used in a resource instance's primary descriptor. Error:
Unable to Delete
This concept or one of it's subconcepts is already in use by an existing resource.

@whatisgalen whatisgalen assigned apeters and unassigned whatisgalen Mar 19, 2020
@apeters apeters assigned whatisgalen and unassigned apeters Mar 20, 2020
@apeters
Copy link
Member Author

apeters commented Mar 20, 2020

It looks like the user, instead of deleting just the concept, was able to delete the entire thesauri and collection. This is what ultimately caused the issue. Can you confirm this?

@whatisgalen
Copy link
Member

Ok yes I can confirm that if you delete the collection and thesauri that reproduces the issue.

@apeters
Copy link
Member Author

apeters commented Jul 8, 2020

fixed in #6377

@apeters apeters closed this as completed Jul 8, 2020
apeters added a commit that referenced this issue Jul 8, 2020
fix concept referenced in primary descriptor being deleted, re #5957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants