Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing localhost urls on development server #10933

Open
wants to merge 2 commits into
base: dev/7.6.x
Choose a base branch
from

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented May 15, 2024

…s.DEBUG, re #10932

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

if DEBUG is true, the url datatype will let you save urls that include "localhost" (useful if a url is pointing to somewhere else in the arches instance)

Issues Solved

#10932

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

Further comments

@whatisgalen whatisgalen linked an issue May 15, 2024 that may be closed by this pull request
@whatisgalen whatisgalen changed the title enables url datatype to pass validation for localhost urls if setting… Enable testing localhost urls on development server May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

url datatype validation regex fails against localhost urls
1 participant