Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of modules with unspecified js/mjs extensions #10992 #11089

Closed
wants to merge 1 commit into from

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Jun 25, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Allows import of js dependencies even if their import statements don't declare a file extension (.js or .mjs) when their type is set to 'module'.
webpack/webpack#11467 (comment)
https://webpack.js.org/configuration/module/#resolvefullyspecified

Issues Solved

Closes #10992

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@chiatt chiatt marked this pull request as draft June 26, 2024 15:35
Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@chiatt
Copy link
Member Author

chiatt commented Jun 26, 2024

lgtm! 👍

Thanks @chrabyrd. There does seem to be an issue with one of the packages used by AFS. @aarongundel and I are still testing to confirm it's not related to this change.

@chrabyrd
Copy link
Contributor

After chatting w/ @aarongundel it looks like this change may not be necessary 👍

@chiatt chiatt closed this Jul 1, 2024
@chiatt chiatt deleted the 10992_module_import_resolution branch July 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants