Updates complex widgets in provisional edit review #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l edit review. re #4384
stickler-ci
reviewed
Feb 17, 2019
| set defaultconfig = jsonb_set(defaultconfig, '{rerender}', to_jsonb(true), true) | ||
| where w.name in ('map-widget', 'file-widget', 'iiif-widget'); | ||
| """, | ||
| """ |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
arches/app/views/resource.py
Outdated
| if len(tile.provisionaledits.keys()) > 0: | ||
| if len(tile.data) == 0: | ||
| isfullyprovisional = True | ||
| if user_is_reviewer == False: |
There was a problem hiding this comment.
E712 comparison to False should be 'if cond is False:' or 'if not cond:'
arches/app/views/resource.py
Outdated
| isfullyprovisional = True | ||
| if user_is_reviewer == False: | ||
| if str(request.user.id) in tile.provisionaledits: | ||
| tile.provisionaledits = {str(request.user.id): tile.provisionaledits[str(request.user.id)]} |
There was a problem hiding this comment.
E501 line too long (123 > 119 characters)
arches/app/views/resource.py
Outdated
| # if the tile has authoritaive data and the current user is not the owner, | ||
| # we don't send the provisional data of other users back to the client. | ||
| tile.provisionaledits = None | ||
| if isfullyprovisional == True: |
There was a problem hiding this comment.
E712 comparison to True should be 'if cond is True:' or 'if cond:'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Forces the map, file, and iiif widgets to re-render when a reviewer switches between user edits during a provisional edit review allowing the reviewer to see the provisional edit data. re #4384