Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve check for createdb privileges during setup_db re: #4941 #4947

Conversation

mradamcox
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Makes a better check for what type of postgres user Arches is provided with. The impetus for this change is that some hosted PG solutions (like AWS RDS) don't provide users with logins that are technically "superusers". However, the logins do have "CREATE DATABASE" ability, which is all that Arches actually needs when it tries to run the create/drop database operation.

Issues Solved

#4941

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by: Legion GIS
  • Designed by: @mradamcox

Further comments

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 42.44% when pulling e75ccc3 on legiongis:4941_improve_pguser_createdb_chk_4.4.x into fef1c58 on archesproject:stable/4.4.x.

@chiatt chiatt merged commit 85ab99d into archesproject:stable/4.4.x Jun 25, 2019
@mradamcox mradamcox deleted the 4941_improve_pguser_createdb_chk_4.4.x branch August 12, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants