Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEIP-2. Comments on Properties #9

Closed
pvalette opened this issue Jul 1, 2022 · 2 comments
Closed

AEIP-2. Comments on Properties #9

pvalette opened this issue Jul 1, 2022 · 2 comments

Comments

@pvalette
Copy link

pvalette commented Jul 1, 2022

Is your feature request related to a problem?

I am sorry I have other concerns about the Properties, hope that will help to progress.

  • Seems that there are 2 roles in properties;
    one is to define some metadata of the token (parent) and to define a list of NFT instances (children). It will be nicer to separate these 2 items in different attributes, on an object and another one a collection.
    metadata:{} & instances: []. (didn't find a better word than instances)

  • Metadata are defined by an item with 2 attributes key/value, as JSON is based on "key:value", it is more efficient (size, implementation to find the value etc..) to use the native approach. example:
    [
    { "key": "origin", "value": "France"},
    { "key": "organism", "value": "DG" }
    ]
    should be
    {
    "origin": "France",
    "organism": "DG
    }

  • For NFT instance, the id should be mandatory and controlled by the developer, I will not recommended to have the index based on the position in a collection (mix representation & business)

Describe the solution you'd like

No response

Additional context

No response

@ghost
Copy link

ghost commented Jul 1, 2022

Hello @pvalette
Thanks for the contribution.

I think the first one is interesting, we thought about it, before.
The "key"/"value", was to make the schema evolutionary and still be validated.
But this can be implemented.

For the second, I don't think should be mandatory, in some other blockchains it's either mandatory or self-defined in the contract (auto or specified). In the AEIP2 there is a mention to give the id in the property field.

@samuelmanzanera
Copy link
Member

Closed by #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants