Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve self-repair summaries download #385

Closed
ghost opened this issue Jun 16, 2022 · 1 comment · Fixed by #400
Closed

Improve self-repair summaries download #385

ghost opened this issue Jun 16, 2022 · 1 comment · Fixed by #400
Labels
core team Assigned to the core team feature New feature request P2P Involve P2P networking self repair Involve SelfRepair mechanism

Comments

@ghost
Copy link

ghost commented Jun 16, 2022

Is your feature request related to a problem?

In development environment this case is really present, but since you are adding some network latency around 150-200ms, the time to get the beacon summaries for all subset for a given date, become really long as minutes.

Hence we should propose a way to optimize the requests to reduce the latency

Describe the solution you'd like

The self-repair could be optimized in few ways:

Batch of the beacon summaries

For now, for each subset, we are doing multi requests to the same node, leading to latency (nb subsets(=256) * latency).

We should aggregate trough the election to know which nodes are responsible for which subset and then aggregate through aGetBeaconSummaries message

Stream responses

Because of the aggregation of summaries, network latencies and timeouts can occurred if the number of summaries and the transaction summaries inside are significant, as it's a single P2P call.

So we can stream transaction summaries like we are streaming transaction in the GetTransactionChain request, by doing multiple calls

Additional context

No response

@ghost ghost added feature New feature request P2P Involve P2P networking self repair Involve SelfRepair mechanism labels Jun 16, 2022
@ghost ghost modified the milestone: Fireworks Jun 17, 2022
@ghost ghost added the core team Assigned to the core team label Jun 17, 2022
@internet-zero
Copy link
Member

Hey team! Please add your planning poker estimate with ZenHub @apoorv-2204 @imnik11 @Neylix @prix-uniris @samuel-uniris

@ghost ghost self-assigned this Jun 20, 2022
@ghost ghost closed this as completed Jun 27, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team Assigned to the core team feature New feature request P2P Involve P2P networking self repair Involve SelfRepair mechanism
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant