Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure network transaction type only passed in a network transaction chain #423

Closed
Tracked by #419
ghost opened this issue Jun 29, 2022 · 3 comments
Closed
Tracked by #419
Assignees
Labels
feature New feature request oracle chain Involve OracleChain rewards shared secrets Involve SharedSecrets

Comments

@ghost
Copy link

ghost commented Jun 29, 2022

Is your feature request related to a problem?

Network transactions are transaction which have a direct impact on the network and replications from shared secrets, to oracle and miner rewards.
Hence not other transaction chain should have the same type, ex: single shared secrets, single miner reward chain, ...

Describe the solution you'd like

We can check the previous public key of the transaction to get previous and perform verification about the last address known by its type of transaction, and hence validate it or not.

So the network transaction types cannot be used by anybody.

Additional context

No response

@ghost ghost added feature New feature request beacon chain Involve BeaconChain oracle chain Involve OracleChain shared secrets Involve SharedSecrets and removed beacon chain Involve BeaconChain labels Jun 29, 2022
@ghost ghost mentioned this issue Jun 29, 2022
4 tasks
@ghost ghost added the rewards label Jun 29, 2022
@ghost
Copy link
Author

ghost commented Jul 1, 2022

Hey team! Please add your planning poker estimate with ZenHub @apoorv-2204 @imnik11 @Neylix @prix-uniris

@Neylix
Copy link
Member

Neylix commented Jul 1, 2022

We can create a common function which takes the previous public key and the transaction type ine parameters and depending of the type it will get the good transaction chain and check if the previous public key is part of this chain

@samuelmanzanera
Copy link
Member

Closed by #495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request oracle chain Involve OracleChain rewards shared secrets Involve SharedSecrets
Projects
None yet
Development

No branches or pull requests

3 participants