Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if transaction exists before validation #502

Closed
ghost opened this issue Aug 10, 2022 · 2 comments
Closed

Verify if transaction exists before validation #502

ghost opened this issue Aug 10, 2022 · 2 comments
Assignees
Labels
API Involve API facing user feature New feature request good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Aug 10, 2022

Is your feature request related to a problem?

Currently, the welcome node doesn't verify if a transaction exists before to send the validation requests.
Even if the validation nodes get the errors where the tx already exists, to avoid wasteful resources, we can prevent upfront the tx validation.

Describe the solution you'd like

We can add a verification in the API when we receive a transaction to submit to the network for validation to check if the transaction exists.
This will imply to request from the storage node if the transaction exists.
We can use the GetTransactionSummary P2P message to check if the transaction exists or not, returning 'NotFoundin that case.

Additional context

No response

@ghost ghost added feature New feature request API Involve API facing user good first issue Good for newcomers labels Aug 10, 2022
@ghost
Copy link
Author

ghost commented Aug 12, 2022

Hey team! Please add your planning poker estimate with ZenHub @apoorv-2204 @imnik11 @Neylix @prix-uniris

@ghost
Copy link
Author

ghost commented Aug 24, 2022

Closed by #536

@ghost ghost closed this as completed Aug 24, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user feature New feature request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant