Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate in origin_key api is not checked #584

Closed
Neylix opened this issue Sep 21, 2022 · 2 comments
Closed

Certificate in origin_key api is not checked #584

Neylix opened this issue Sep 21, 2022 · 2 comments
Assignees
Labels
API Involve API facing user bug Something isn't working origin

Comments

@Neylix
Copy link
Member

Neylix commented Sep 21, 2022

Describe the problem you discovered

Actually, when origin public key is not tpm family, we do not control the certificate.
But someone can put some data in the certificate attribute in the api and so create a transaction with some data inside.
As origin transaction are free and generated by nodes, people can create not tpm public key and store data in the transaction for free

Describe the solution you'd like

In the API or in pending validation, if the origin public key is not tpm family, certificate should be empty

@Neylix Neylix added bug Something isn't working API Involve API facing user origin labels Sep 21, 2022
@samuelmanzanera
Copy link
Member

samuelmanzanera commented Sep 21, 2022

We should maybe leverage: Crypto.verify_key_certificate? to attest the public key with the certificate.
In link with Crypto.get_root_ca_public_key

@samuelmanzanera
Copy link
Member

Closed by #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user bug Something isn't working origin
Projects
None yet
Development

No branches or pull requests

3 participants