Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid the authorized nodes in the node shared secret #694

Closed
Neylix opened this issue Nov 17, 2022 · 0 comments · Fixed by #715
Closed

Valid the authorized nodes in the node shared secret #694

Neylix opened this issue Nov 17, 2022 · 0 comments · Fixed by #715
Assignees
Labels
bug Something isn't working shared secrets Involve SharedSecrets

Comments

@Neylix
Copy link
Member

Neylix commented Nov 17, 2022

Describe the problem you discovered

Actually during the pending validation, we control if the new authorized nodes in the node shared secret transaction are part of the candidate, but we do not verify if the selected ones are the good ones.

Describe the solution you'd like

We should not verify if the new authorized nodes are part of the candidate, but directly verify that all authorized nodes are the same as the return of the function NodeRenewal.next_authorized_node_public_keys()

@Neylix Neylix added bug Something isn't working shared secrets Involve SharedSecrets labels Nov 17, 2022
@tenmoves tenmoves self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shared secrets Involve SharedSecrets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants