Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome node should forward tx if not synced #872

Closed
Tracked by #896
Neylix opened this issue Jan 26, 2023 · 1 comment · Fixed by #896
Closed
Tracked by #896

Welcome node should forward tx if not synced #872

Neylix opened this issue Jan 26, 2023 · 1 comment · Fixed by #896
Assignees
Labels
API Involve API facing user bug Something isn't working shared secrets Involve SharedSecrets

Comments

@Neylix
Copy link
Member

Neylix commented Jan 26, 2023

Describe the problem you discovered

When a welcome node receive a transaction, it will perform the election for validation nodes and send to them the StartMining message.
But if the welcome node is out of sync and don't have the last node shared secret, it's election will be wrong (election or proof of election).

Describe the solution you'd like

To fix this, when receiving a transaction, the welcome node should verify that it has the last node shared secret transaction.
If yes, continue as actually, if not we have 3 options:

  • Forward the transaction to another authorized node
  • Request the last node shared secret transaction and replicate it, then continue to send the transaction (if multiple transaction are received, the node may try to replicate multiple time the shared secret)
  • Forward the transaction to another authorized node, and try to replicate the last node shared secret (if multiple transaction are received, the node may try to replicate multiple time the shared secret)

We should take care to continue to have the right welcome node which is the first one the client sent his transaction

@Neylix Neylix added bug Something isn't working API Involve API facing user shared secrets Involve SharedSecrets labels Jan 26, 2023
@internet-zero
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user bug Something isn't working shared secrets Involve SharedSecrets
Projects
Status: Done 🍻
Development

Successfully merging a pull request may close this issue.

3 participants