Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/test-release.sh should support an argument #891

Closed
tenmoves opened this issue Feb 6, 2023 · 1 comment
Closed

scripts/test-release.sh should support an argument #891

tenmoves opened this issue Feb 6, 2023 · 1 comment
Labels
feature New feature request good first issue Good for newcomers testing Improve testing

Comments

@tenmoves
Copy link
Contributor

tenmoves commented Feb 6, 2023

Is your feature request related to a problem?

Right now we create 2 erlang vms to test the release, we want to extend this functionality and make the script accept an integer argument and create as many erlang vms as this argument.

Describe the solution you'd like

refactor the script to accept a integer as argument and create as many vms.
argument should be between 1 and 8.
scripts/test-release.sh --instances 5 should create 5 vm instances
scripts/test-release.sh --instances 0 should return an error (value not between 1 and 8)

@tenmoves tenmoves added feature New feature request good first issue Good for newcomers testing Improve testing labels Feb 6, 2023
@Neylix
Copy link
Member

Neylix commented Jul 27, 2023

Issue fixed by #1117

@Neylix Neylix closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request good first issue Good for newcomers testing Improve testing
Projects
Status: Done 🍻
Development

No branches or pull requests

2 participants