Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix governance validation workflow #971

Open
tenmoves opened this issue Apr 4, 2023 · 0 comments
Open

fix governance validation workflow #971

tenmoves opened this issue Apr 4, 2023 · 0 comments
Labels
feature New feature request Governance About On-Chain governance

Comments

@tenmoves
Copy link
Contributor

tenmoves commented Apr 4, 2023

Is your feature request related to a problem?

When receiving a code validation and it is validated by enough members of technical council it triggers CI worklflow and then CD workflow.

inside the CD workflow we trigger a validator container responsible for testing that everything works correctly in a testnet mode (multiple nodes connected), for this we need to for example measure benchmarks before and after applying the code proposal to make sure that there is no huge drop in metrics (for now the data is not used).

Describe the solution you'd like

we are doing a Process.sleep to make sure the container is still running between phase 1 and phase 2, but the duration of the sleep is arbitrary so for some slow machines it will not work also this not an elegant solution.

the best solution would be either to separate the validation workflow in 2 containers with a shared volume and only start validator_2 after we validated that validator_1 is done accordingly to the correct step in global cd workflow.

Another possible solution is to build validator_2 using validator_1 image (using docker commit) but I think first solution is more composable and extendable.

however we need to be sure that ip address given to the container is in the same subnet as the other container and that all nodes are still running in each validation step.

Additional context

Epic: #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request Governance About On-Chain governance
Projects
Status: Todo 🚩
Development

Successfully merging a pull request may close this issue.

2 participants