Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts: trigger datetime should be rounded to the minute. #992

Closed
bchamagne opened this issue Apr 21, 2023 · 1 comment · Fixed by #1107
Closed

Smart Contracts: trigger datetime should be rounded to the minute. #992

bchamagne opened this issue Apr 21, 2023 · 1 comment · Fixed by #1107
Assignees
Labels
bug Something isn't working smart contracts Involve smart contracts
Milestone

Comments

@bchamagne
Copy link
Member

bchamagne commented Apr 21, 2023

Describe the problem you discovered

With current datetime worflow, there is a possibility for a contract to run every second.
We must handle this case by rounding the datetime to the closest minute.

Describe the solution you'd like

No response

Additional context

Epic: #608

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels Apr 21, 2023
@samuelmanzanera
Copy link
Member

We could probably check in the interpreter parser than the timestamp should not include second (only 0s) . Hence the timestamp would always be minute based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
Status: Done 🍻
Development

Successfully merging a pull request may close this issue.

2 participants