Fix undefined variable in get_plugin_base_file
#524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cross-posted in https://wordpress.org/support/topic/undefined-variable-in-class-utilities/. The WordPress support thread was closed to keep conversation in one place, but conversation didn't start here... |
|
Hi, thanks for the heads up! This has been fixed in a slightly different way (to maintain consistency with other code) as part of a recent audit. |
|
Do you have any idea when this will be part of the core plugin? Haven't seen any recent commit. |
archetyped
added a commit
that referenced
this pull request
Nov 5, 2016
Props xavivars (via PR #524)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem in
get_plugin_base_fileand it only works when there's no predefined data. Once data has been obtained once , it doesn't work anymore, because it returns the wrong variable.