Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling a container other than document.body #7

Closed
finkrer opened this issue May 22, 2023 · 2 comments
Closed

Scrolling a container other than document.body #7

finkrer opened this issue May 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@finkrer
Copy link

finkrer commented May 22, 2023

I've just realized a use case is not supported when we are scrolling not inside the document body but inside an inner element. I have a full-viewport modal overlay with a table inside of it. It looks and behaves like a separate page but is in fact just a container sitting on top of a previous page.

Right now there is no way to specify a different target container for position calculations and scroll events. It could be done by optionally passing a ref, like you can currently specify the table container and such.

@archfz archfz added the enhancement New feature or request label May 22, 2023
@archfz
Copy link
Owner

archfz commented May 27, 2023

Release in 1.5.0

@archfz archfz closed this as completed May 27, 2023
@finkrer
Copy link
Author

finkrer commented May 30, 2023

Thank you, it works — and on its own, too! I just updated the package and the issue was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants