feat(bytecode): add modifier support

archguard · Mar 28, 2022 · 7bd03bc · 7bd03bc
1 parent bdd75e4
commit 7bd03bc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/scan_bytecode/src/main/kotlin/org/archguard/scanner/bytecode/ByteCodeParser.kt b/scan_bytecode/src/main/kotlin/org/archguard/scanner/bytecode/ByteCodeParser.kt
@@ -116,9 +116,12 @@ class ByteCodeParser {
     }
 
     private fun createField(field: FieldNode): CodeField {
+        val isInterface = CodeConstants.ACC_INTERFACE == field.access
+
         return CodeField(
             TypeType = Type.getType(field.desc).className,
-            TypeValue = field.name
+            TypeValue = field.name,
+            Modifiers = createModifiers(field.access, FIELD_ALLOWED, isInterface, FIELD_EXCLUDED)
         )
     }
 

diff --git a/scan_bytecode/src/test/kotlin/org/archguard/scanner/bytecode/ByteCodeParserTest.kt b/scan_bytecode/src/test/kotlin/org/archguard/scanner/bytecode/ByteCodeParserTest.kt
@@ -85,5 +85,6 @@ internal class ByteCodeParserTest {
         assertEquals(1, ds.Fields.size)
         assertEquals("hello", ds.Fields[0].TypeValue)
         assertEquals("com.example.demo.Hello", ds.Fields[0].TypeType)
+        assertEquals("private", ds.Fields[0].Modifiers[0])
     }
 }