feat(rule): enable rules for visit

rule_core/build.gradle.kts

@@ -1,8 +1,9 @@
 plugins {
     kotlin("jvm") version "1.6.10"
-    id("com.github.johnrengelman.shadow") version "7.0.0"
+    kotlin("plugin.serialization") version "1.6.10"
 }
 
 dependencies {
     implementation("com.phodal.chapi:chapi-domain:1.5.6")
+    implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.3.2")
 }

rule_core/src/main/kotlin/org/archguard/rule/core/Rule.kt

@@ -1,5 +1,7 @@
 package org.archguard.rule.core
 
+import chapi.domain.core.CodeDataStruct
+
 enum class Severity {
     // ERROR -> BLOCKER can be for continuous integration
     HINT, WARN, INFO, BLOCKER
@@ -32,7 +34,7 @@ enum class RuleType {
     ORGANIZATION,
 }
 
-open class Rule(
+abstract class Rule(
     var key: String = "",
     // rule name for identify
     var name: String = "",
@@ -51,7 +53,7 @@ open class Rule(
     // custom for search
     var tags: List<String> = listOf()
 ) {
-
+    open fun visit(rootNode: CodeDataStruct, callback: () -> Unit) {}
 }
 
 abstract class IfttRule : Rule() {

rule_core/src/main/kotlin/org/archguard/rule/core/RuleVisitor.kt

@@ -0,0 +1,5 @@
+package org.archguard.rule.core
+
+interface RuleVisitor {
+
+}

rule_core/src/main/kotlin/org/archguard/rule/impl/tbs/TbsRule.kt

@@ -1,7 +1,18 @@
 package org.archguard.rule.impl.tbs
 
+import chapi.domain.core.CodeDataStruct
 import org.archguard.rule.core.Rule
 
 open class TbsRule: Rule() {
-    // tbs context?
+    override fun visit(rootNode: CodeDataStruct, callback: () -> Unit) {
+        if(this.given.isNotEmpty()) {
+            processGivenCondition()
+        } else {
+            // todo: call by interface
+        }
+    }
+
+    private fun processGivenCondition() {
+
+    }
 }

rule_core/src/main/kotlin/org/archguard/rule/impl/tbs/TestSmellProvider.kt

@@ -4,6 +4,9 @@ import org.archguard.rule.core.RuleSet
 import org.archguard.rule.core.RuleSetProvider
 import org.archguard.rule.core.RuleType
 import org.archguard.rule.impl.CasingRule
+import org.archguard.rule.impl.tbs.rules.EmptyTestRule
+import org.archguard.rule.impl.tbs.rules.NoIgnoreTestRule
+import org.archguard.rule.impl.tbs.rules.SleepyTestRule
 
 /*
  * Low level provider
@@ -13,7 +16,10 @@ class TestSmellProvider: RuleSetProvider {
         return RuleSet(
             RuleType.CHANGE_SMELL,
             "normal",
-            CasingRule()
+            CasingRule(),
+            EmptyTestRule(),
+            NoIgnoreTestRule(),
+            SleepyTestRule(),
         )
     }
 }

rule_core/src/main/kotlin/org/archguard/rule/impl/tbs/TestSmellVisitor.kt

@@ -0,0 +1,17 @@
+package org.archguard.rule.impl.tbs
+
+import chapi.domain.core.CodeDataStruct
+import org.archguard.rule.core.RuleSet
+import org.archguard.rule.core.RuleVisitor
+
+class TestSmellVisitor: RuleVisitor {
+    internal fun visitor(ruleSets: Iterable<RuleSet>, rootNode: CodeDataStruct) {
+        ruleSets.forEach { ruleSet ->
+            ruleSet.rules.forEach {
+                it.visit(rootNode) {
+                    return@visit
+                }
+            }
+        }
+    }
+}

rule_core/src/main/kotlin/org/archguard/rule/impl/tbs/rules/EmptyTestRule.kt

@@ -8,8 +8,6 @@ class EmptyTestRule: TbsRule() {
         this.key = this.javaClass.name
         this.description = "Some casing description"
         // rule for AstPath or ognl?
-        this.given = listOf(
-            "$.class.function.annotation == 'Ignore'"
-        )
+        this.given = listOf("$.class.function.calls <= 0")
     }
 }

rule_core/src/main/kotlin/org/archguard/rule/impl/tbs/rules/NoIgnoreTestRule.kt

@@ -8,6 +8,6 @@ class NoIgnoreTestRule : TbsRule() {
         this.key = this.javaClass.name
         this.description = "Some casing description"
         // rule for AstPath or ognl?
-        this.given = listOf("$.class.function.calls <= 0")
+        this.given = listOf("$.class.function.annotations contains 'Ignore'")
     }
 }

rule_core/src/main/kotlin/org/archguard/rule/ruleset/CustomRuleSetsLoader.kt

@@ -1,6 +1,5 @@
 package org.archguard.rule.ruleset
 
-import org.archguard.rule.core.RuleSet
 import org.archguard.rule.core.RuleSetProvider
 
 abstract class CustomRuleSetsLoader : RuleSetProvider {

rule_core/src/test/kotlin/org/archguard/rule/impl/tbs/TestSmellVisitorProviderTest.kt

@@ -0,0 +1,17 @@
+package org.archguard.rule.impl.tbs
+
+import chapi.domain.core.CodeDataStruct
+import org.junit.jupiter.api.Test
+
+internal class TestSmellVisitorProviderTest {
+    @Test
+    internal fun name() {
+        val provider = TestSmellProvider()
+        val visitor = TestSmellVisitor()
+
+        val ds = CodeDataStruct()
+
+        visitor
+            .visitor(listOf(provider.get()), ds)
+    }
+}