hash functions: add tests to verify output against test vectors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was discovered in the sha256 hash functions provided by this library but the mistake was not caught for a long time because no tests were run using known test vectors. The test vectors used in this commit are from publicly available and well-respected sources (NIST and the original author of ripe-md). You can run the tests with "make check". Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
hashing-test-vectors
branch
from
738c510
to
76377ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered in the sha256 hash functions provided by this library (see #4) but the mistake was not caught for a long time because no tests were run using known test vectors.
The test vectors used in this commit are from publicly available and well-respected sources (NIST and the original author of ripe-md).
You can run the tests with "make check".