Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableDocElement shouldn't render anything if the items are empty #75

Closed
nils-christian opened this issue Sep 27, 2021 · 2 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nils-christian
Copy link
Contributor

If the items of the TableDocElement are empty, the table shouldn't render anything. Alternatively, it should be configurable whether an empty table should still be rendered (default: false).

@nils-christian nils-christian added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2021
@OLibutzki
Copy link
Contributor

OLibutzki commented Sep 27, 2021

Not sure about this issue. In my opinion it's the responsibility of the client whether the table should be rendered or not. If there are no elements to be displayed it's possible to omit the creation of TableDocElement entirely.

I can think of cases when you want to show explicitly that there are no elements in a certain table.
Yes, we can make it configurable, but do we win anything compared to an if in the client's code?

@nils-christian
Copy link
Contributor Author

I would say that it would be just a convenient function, but I agree that such a behaviour is not available for component in other areas (web or desktop frontends). Therefore I withdraw this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants