Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning Icon #912

Closed
jbsarrodie opened this issue Feb 20, 2023 · 8 comments
Closed

Meaning Icon #912

jbsarrodie opened this issue Feb 20, 2023 · 8 comments

Comments

@jbsarrodie
Copy link
Member

jbsarrodie commented Feb 20, 2023

Let's open this issue to discuss the meaning icon

@jbsarrodie jbsarrodie changed the title Eaning Meaning Icon Feb 20, 2023
@Phillipus
Copy link
Member

I can discuss the meaning of life...

jbsarrodie pushed a commit that referenced this issue Feb 20, 2023
@jbsarrodie
Copy link
Member Author

I can discuss the meaning of life...

;-)

I've just pushed a proposal for an enhanced Meaning icon. It is based on bezier curves. I've configured it so that points and control points are on a 12x7 grid (easier to manage). You can do simulations using this online tool and setting this background image.

Here's what I used while coding:
image

@Phillipus
Copy link
Member

Beautiful. :-)

But you missed an important change:

Remove this comment:

// The following is the most awful code to draw a cloud...

and replace with something appropriate. ;-)

@Phillipus
Copy link
Member

The path code is duplicated could it be used just once?

@jbsarrodie
Copy link
Member Author

The path code is duplicated could it be used just once?

If everything else is ok, then, yes, I can refactor it (and add a helper function to simplify the calls to .cubicTo())

@Phillipus
Copy link
Member

If everything else is ok

Superb work! 👏

I can refactor it

Please do. Do a force push if you can. :-)

jbsarrodie pushed a commit that referenced this issue Feb 23, 2023
@jbsarrodie
Copy link
Member Author

Please do. Do a force push if you can. :-)

Done ;-)

@Phillipus
Copy link
Member

Merged to master, thank-you. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants