Skip to content

Commit

Permalink
[ifmeorg#649] in Workflow.md create a link to a wiki for how to creat…
Browse files Browse the repository at this point in the history
…e a pull request and syncing
  • Loading branch information
architapatelis committed Oct 7, 2017
1 parent 6d5743d commit 97de030
Showing 1 changed file with 1 addition and 21 deletions.
22 changes: 1 addition & 21 deletions documentation/WORKFLOW.md
Expand Up @@ -55,27 +55,7 @@ working on! **Always make pull requests!**

### HOW TO: Pull Requests & Syncing

1. Fork the if me repo (if you haven't already done so).
2. [Clone](https://help.github.com/articles/cloning-a-repository/) it to your computer.
3. When you're ready to work on an issue, be sure you're on the master branch. From there, [create a separate branch](https://github.com/Kunena/Kunena-Forum/wiki/Create-a-new-branch-with-git-and-manage-branches) (e.g. issue_32).
4. Make your changes. If you're unsure of some details while you're making edits, you can discuss them on the ticket or in Slack.
5. Commit your changes.
6. Push the working branch (e.g. issue_32) to your remote fork.
7. Make the pull request (on the [upstream master branch](https://github.com/julianguyen/ifme/tree/master))
- Do not merge it with the master branch on your fork. That would result in multiple, or unrelated patches being included in a single PR.
8. If any further changes need to be made, comments will be made on the pull request.

It's possible to work on two or more different patches (and therefore multiple branches) at one time, but it's recommended that beginners only work on one patch at a time.

#### Syncing

Periodically, you'll need to sync your repo with mine (the upstream). GitHub has instructions for doing this.

1. [Configuring a remote for a fork](https://help.github.com/articles/configuring-a-remote-for-a-fork/)
- For step 3 on that page, use https://github.com/julianguyen/ifme.git for the URL.
2. [Syncing a Fork](https://help.github.com/articles/syncing-a-fork/)
- On that page, it shows how to merge the master branch (steps 4 & 5).
3. When your patch is completed, do not merge your patch into the master branch of your locally cloned fork. Your patch will be merged when you sync with the remote fork.
You can learn more about how to create a pull request and sync your forked repo with the upstream(ifme) repo [here](https://github.com/julianguyen/ifme/wiki/HOW-TO:-Pull-Requests-&-Syncing)

If you've been added as a collaborator to the repository, please do not push
unless the commit you are making is _trivial_ i.e. doesn't require a code
Expand Down

0 comments on commit 97de030

Please sign in to comment.