-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
446 project command #612
446 project command #612
Conversation
This is definitely on the right track but there are some changes we should make.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there is some high level things we should fix first, once those are done I will do another deep dive pass since these require some big code changes.
522eb02
to
d268f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like we are getting very close!
@mueschm @tjhiggins Init command is ready to go and tested. As a quick note - put a PR for the config template , so the latest projects won't show in the selections until after it's merged (ASP, Ruby) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small changes - also I noticed this has an empty creds.json
committed. I think one of the tests always adds that empty file and we have it .gitignore
'd in the tests/ directory, but it gets created wherever you run tests from... could you remove that file and add it to the .gitignore
as well?
Code-wise everything looks good now, I just tried out the tool and noticed a couple things that are a bit misleading that we should reword:
This doesn't seem to actually be the name of the component, but rather the folder that we create to clone the project into. I tested out cloning the Go project and I end up with a file structure like:
At the end, we then say:
This isn't accurate because we create the Perhaps what we should do to fix this is:
With the updated clone command the final message won't be a lie and the |
…e location to be the project root
Realized Zach was out today so I fixed the things I suggested above |
@TylerAldrich muchas gracias |
# [1.29.0](v1.28.0...v1.29.0) (2022-12-01) ### Bug Fixes * **cluster:** Updated examples to remove type flag. ([4e58979](4e58979)) * **dev:** Fix race condition inspecting containers that no longer exist, fixed bug with service_ref / full_service_name being incorrect, only log healthcheck once each time it happens ([#763](#763)) ([734356a](734356a)) * **register:** Default register path to ./architect.yml ([#765](#765)) ([01fa335](01fa335)) * **register:** Fix warning when dependencies are already registered ([#766](#766)) ([a593ea9](a593ea9)) * **validation:** validator for looser validation on account names ([#761](#761)) ([93d6859](93d6859)) ### Features * **dev:** loading a .env file for architect environment variables ([#753](#753)) ([dc0f0bc](dc0f0bc)) * **dev:** Log errors when liveness probe fails ([#759](#759)) ([0c65d19](0c65d19)) * **environment:create:** Warn when environment creation fails due to already existing environment ([#556](#556)) ([bb17f80](bb17f80)) * **init:** Support creating projects from Architect templates ([#612](#612)) ([45283a0](45283a0)), closes [#695](#695) * **secrets:** Allow secrets from a remote env to be used in local development ([012e459](012e459))
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.