Remove parameters #808
Merged
Remove parameters #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding WIP - not for the code, but we need the remaining customers to migrate first |
ryan-cahill
approved these changes
Jan 25, 2023
Merge remote-tracking branch 'origin/rc' into 404-remove-parameters
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
# [1.34.0-rc.2](v1.34.0-rc.1...v1.34.0-rc.2) (2023-03-01) ### Bug Fixes * **spec:** Remove parameters ([#808](#808)) ([72cb793](72cb793))
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
# [1.34.0](v1.33.2...v1.34.0) (2023-03-07) ### Bug Fixes * **cluster:create:** Make sure a cluster name is unique before creation ([#840](#840)) ([27d14f7](27d14f7)) * **deploy:** Add missing flags from register to deploy ([#849](#849)) ([61c3349](61c3349)) * **dev:restart:** Default --build to true ([#847](#847)) ([dbf8cc0](dbf8cc0)) * **dev:** Update description of environment flag to emphasize it is for local use only ([e9a66c4](e9a66c4)) * **init:** Depends on now supports dictionaries ([#848](#848)) ([30fedca](30fedca)) * **register:** Hard remove old cache directory before renaming ([#846](#846)) ([a9e2720](a9e2720)) * **spec:** Remove parameters ([#808](#808)) ([72cb793](72cb793)) ### Features * **dev:restart:** Add dev:restart command ([#842](#842)) ([93d10cf](93d10cf))
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove all the deprecated
parameters.PRs:
https://gitlab.com/architect-io/hub-api/-/merge_requests/691
https://gitlab.com/architect-io/architect-hub/-/merge_requests/690
Changes
Delete and update any code where parameters were used in the CLI, API and cloud.
Tests
Added parameters in the architect.yml of the hello-world example
$ architect dev
$ architect-dev register
