Fix getLocalEnvironment failing on older versions of compose without ConfigFiles #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
# [1.25.0-rc.1](v1.24.0...v1.25.0-rc.1) (2022-09-01) ### Bug Fixes * **cli:** convert deployCommand auto-approve ([#685](#685)) ([78f3209](78f3209)) * **cli:** Docker verify improved ([#679](#679)) ([552cd77](552cd77)) * **dev:** Dev command leaves containers running when process exits with an error ([#677](#677)) ([b8e5165](b8e5165)) * **dev:** Fixed host regex that shouldnt have a global match that caused regexp.exec to not work as desired ([#689](#689)) ([1a6428d](1a6428d)) * **dev:** fixing healthcheck liveness probe protocol for port/path ([#678](#678)) ([81e69f0](81e69f0)) * **dev:** Handle edge cases when starting components with pre-existing containers ([9cffb28](9cffb28)) * **exec:** Handle case where older version of compose is used and ConfigFiles doesnt exist ([#681](#681)) ([c0112d2](c0112d2)) * **exec:** Handle terminal resize events in exec ([#675](#675)) ([6ff95a5](6ff95a5)) * **exec:** Improve error message for Windows PS users ([#680](#680)) ([c214870](c214870)) * **subdomain:** 488 prevent nested subdomain ([#674](#674)) ([0445430](0445430)) ### Features * **cli:** 496 consistent boolean flags ([#683](#683)) ([4203c74](4203c74)) * **dev:** Use local SSL for ([#676](#676)) ([536b38e](536b38e)) * **exec:** 482 pass replica name ([#663](#663)) ([84ce8c5](84ce8c5)) * **register:** add register multiple components and test cases ([#657](#657)) ([2bd1fd2](2bd1fd2))
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
# [1.25.0](v1.24.0...v1.25.0) (2022-09-01) ### Bug Fixes * **cli:** convert deployCommand auto-approve ([#685](#685)) ([78f3209](78f3209)) * **cli:** Docker verify improved ([#679](#679)) ([552cd77](552cd77)) * **dev:** Dev command leaves containers running when process exits with an error ([#677](#677)) ([b8e5165](b8e5165)) * **dev:** Fixed host regex that shouldnt have a global match that caused regexp.exec to not work as desired ([#689](#689)) ([1a6428d](1a6428d)) * **dev:** fixing healthcheck liveness probe protocol for port/path ([#678](#678)) ([81e69f0](81e69f0)) * **dev:** Handle edge cases when starting components with pre-existing containers ([9cffb28](9cffb28)) * **exec:** Handle case where older version of compose is used and ConfigFiles doesnt exist ([#681](#681)) ([c0112d2](c0112d2)) * **exec:** Handle terminal resize events in exec ([#675](#675)) ([6ff95a5](6ff95a5)) * **exec:** Improve error message for Windows PS users ([#680](#680)) ([c214870](c214870)) * **subdomain:** 488 prevent nested subdomain ([#674](#674)) ([0445430](0445430)) ### Features * **cli:** 496 consistent boolean flags ([#683](#683)) ([4203c74](4203c74)) * **dev:** Use local SSL for ([#676](#676)) ([536b38e](536b38e)) * **exec:** 482 pass replica name ([#663](#663)) ([84ce8c5](84ce8c5)) * **register:** add register multiple components and test cases ([#657](#657)) ([2bd1fd2](2bd1fd2))
|
🎉 This PR is included in version 1.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of
docker composedon't have aConfigFileskey when runningdocker compose ls. I installed docker compose v2.2.3 from January and this key isn't yet available.It's ideal to use this value directly if it exists, but if it doesn't, we fall back to manually searching the
LOCAL_DEPLOY_PATHdirectory and matching the files there up with the results ofdocker compose ls(which still gives us the name of the compose file).Tested this on my Windows machine that has the older version of docker compose installed, and tested on my Mac that has the most up to date Docker, so the old path is working as it did prior and the new path now fixes the bug.
Bug in question is https://sentry.io/organizations/architect-io/issues/3493163125/?project=6465948&referrer=slack