582 602 expected docker compose err

src/commands/dev/index.ts

@@ -503,7 +503,14 @@ export default class Dev extends BaseCommand {
       build_args.push('--build-arg', arg);
     }
 
-    await DockerComposeUtils.dockerCompose(['-f', compose_file, '-p', project_name, 'build', ...build_args], { stdio: 'inherit' });
+    try {
+      await DockerComposeUtils.dockerCompose(['-f', compose_file, '-p', project_name, 'build', ...build_args], { stdin: 'inherit', stdout: 'inherit', stderr: 'pipe' });
+    } catch (e: any) {
+      if (e.exitCode !== 0) {
+        this.logToStderr(chalk.red('Docker compose has encounted an error building the specified image:'));
+        throw new ArchitectError(e.stderr);
+      }
+    }
     return [project_name, compose_file];
   }
 

src/dependency-manager/utils/files.ts

@@ -2,6 +2,7 @@ import fs from 'fs';
 import yaml from 'js-yaml';
 import path from 'path';
 import untildify from 'untildify';
+import { ArchitectError } from './errors';
 import { ParsedYaml } from './types';
 
 // https://stackoverflow.com/questions/4253367/how-to-escape-a-json-string-containing-newline-characters-using-javascript
@@ -38,6 +39,9 @@ export const insertFileDataFromRefs = (file_contents: string, config_path: strin
 };
 
 export const replaceFileReference = (parsed_yml: ParsedYaml, config_path: string): string => {
+  if ((parsed_yml || '').toString().trim().length === 0) {
+    throw new ArchitectError(`The file at ${config_path} is empty.  For help getting started take a look at our documentation here: https://docs.architect.io/reference/architect-yml`);
+  }
   const source_as_json = JSON.stringify(parsed_yml, null, 2);
   const replaced_source = insertFileDataFromRefs(source_as_json, config_path);
   const replaced_object = JSON.parse(replaced_source);

test/commands/dev/index.test.ts

@@ -1330,4 +1330,21 @@ describe('local dev environment', function () {
       const runCompose = Dev.prototype.runCompose as sinon.SinonStub;
       expect(runCompose.calledOnce).to.be.false;
     });
+
+  test
+    .timeout(20000)
+    .stub(ComponentBuilder, 'loadFile', () => {
+      return '';
+    })
+    .stub(Dev.prototype, 'failIfEnvironmentExists', sinon.stub().returns(undefined))
+    .stub(Dev.prototype, 'runCompose', sinon.stub().returns(undefined))
+    .stub(Dev.prototype, 'downloadSSLCerts', sinon.stub().returns(undefined))
+    .stub(Dev.prototype, 'readSSLCert', sinon.stub().returns('fake-cert'))
+    .stdout({ print })
+    .stderr({ print })
+    .command(['dev', './examples/hello-world/architect.yml'])
+    .catch(err => {
+      expect(err.message).to.include('For help getting started take a look at our documentation here: https://docs.architect.io/reference/architect-yml');
+    })
+    .it('Provide error if architect.yml is empty');
 });