@aws-lite/s3
#17
Merged
@aws-lite/s3
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically just the chunked / streamed upload part
Tidy up property names Experiment with adding comments to methods Experiment with moving AWS doc links into a method property
Update plugin template
Will probably put this in a plugin lib shortly
…uest()` hook Add links to docs in errors
Add simple progress indication when debugging HTTP streaming
Include response headers in error output (where available) Add plugin helper utils section to readme
Fix tests borken by previous changes Update readme
Move common `@aws-lite/s3` code into a lib file
…to strings Override aws4 default by using `application/octet-stream` as default `content-type` Empty API response bodies are now returned as `null` payloads Detect and stringify XML response bodies Add response debug output
Add additional information about passing readable streams as payload
Fix `response()` payload marshalling property bug Ensure `request()` is indeed optional
Dry up some common code in the other methods
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically just the chunked / streamed upload part
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
masternpm itfrom the repo root)readme.md, help docs, inline docs & comments, etc.)changelog.mdPlease also be sure to completed the CLA (if you haven't already).
Learn more about contributing to Architect here.
Thanks again!