Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 ListBuckets operation #51

Merged
merged 1 commit into from Dec 11, 2023
Merged

Conversation

metadaddy
Copy link
Contributor

@metadaddy metadaddy commented Dec 11, 2023

Thank you for helping out! ✨

You're welcome!

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from master
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

I think I've done everything I need to do:

  • There do not yet seem to be any tests for S3 operations, so I didn't add anything specific to ListBuckets.
  • There doesn't seem to be a changelog.md.
  • I think you need a more specific checklist for aws-lite πŸ˜‰

Please also be sure to completed the CLA (if you haven't already).

I don't see a CLA, but section D.6 of GitHub's terms of service fulfills the same purpose.

CLA signed!

Do let me know if there's anything I've missed πŸ‘πŸ»

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2023

CLA assistant check
All committers have signed the CLA.

@ryanblock ryanblock merged commit 7a85c56 into architect:main Dec 11, 2023
15 checks passed
@ryanblock
Copy link
Member

@metadaddy hey, I think something weird happened in the git history, not sure what the deal is. Would you mind reopening and force pushing this once more so I can merge and release? Thanks!

@metadaddy
Copy link
Contributor Author

For the record - everything is good - no rework required πŸ‘πŸ»

@metadaddy metadaddy deleted the list-buckets branch December 13, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants