New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: api gateway management api on /_arc/ws #640
Merged
ryanblock
merged 5 commits into
architect:management-api
from
reconbot:reconbot/management-api
Nov 11, 2021
Merged
feat: api gateway management api on /_arc/ws #640
ryanblock
merged 5 commits into
architect:management-api
from
reconbot:reconbot/management-api
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
force-pushed
the
reconbot/management-api
branch
from
August 21, 2021 03:09
bb4cc69
to
17559f8
Compare
reconbot
added a commit
to reconbot/graphql-lambda-subscriptions
that referenced
this pull request
Aug 21, 2021
- fix error handling for validation and execution execution context errors to send an Error message - change the onSubscribe Callback to send an Error message to allow denying a subscription without trashing the connection - change the testing execution helper to have a stream of websocket events instead of using the graphql-ws client, this lets us more easily compare outputs between the servers - port testing to a branch of the arc sandbox that fully supports the api gateway management api (architect/sandbox#640)
reconbot
added a commit
to reconbot/graphql-lambda-subscriptions
that referenced
this pull request
Aug 21, 2021
- fix error handling for validation and execution execution context errors to send an Error message - change the onSubscribe Callback to send an Error message to allow denying a subscription without trashing the connection - change the testing execution helper to have a stream of websocket events instead of using the graphql-ws client, this lets us more easily compare outputs between the servers - port testing to a branch of the arc sandbox that fully supports the api gateway management api (architect/sandbox#640)
reconbot
added a commit
to reconbot/graphql-lambda-subscriptions
that referenced
this pull request
Aug 21, 2021
- fix error handling for validation and execution execution context errors to send an Error message - change the onSubscribe Callback to send an Error message to allow denying a subscription without trashing the connection - change the testing execution helper to have a stream of websocket events instead of using the graphql-ws client, this lets us more easily compare outputs between the servers - port testing to a branch of the arc sandbox that fully supports the api gateway management api (architect/sandbox#640)
reconbot
added a commit
to reconbot/graphql-lambda-subscriptions
that referenced
this pull request
Aug 21, 2021
- fix error handling for validation and execution execution context errors to send an Error message - change the onSubscribe Callback to send an Error message to allow denying a subscription without trashing the connection - change the testing execution helper to have a stream of websocket events instead of using the graphql-ws client, this lets us more easily compare outputs between the servers - port testing to a branch of the arc sandbox that fully supports the api gateway management api (architect/sandbox#640) BREAKING CHANGE: onSubscribe now sends error messages instead of disconnecting
reconbot
force-pushed
the
reconbot/management-api
branch
5 times, most recently
from
August 24, 2021 14:53
7adf88d
to
89fffae
Compare
reconbot
force-pushed
the
reconbot/management-api
branch
from
August 24, 2021 15:39
89fffae
to
8e8679a
Compare
reconbot
commented
Aug 24, 2021
src/arc/_ws/index.js
Outdated
if (req.method === 'GET') { | ||
const output = { | ||
ConnectedAt: new Date(pool.getConnectedAt(connectionId)).toISOString(), | ||
// LastActiveAt: 'I wish this was easy to figure out but it is optional', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find anything in ws
that lets us know this.
reconbot
force-pushed
the
reconbot/management-api
branch
2 times, most recently
from
September 7, 2021 18:50
94c1976
to
05cf0e8
Compare
rebased |
reconbot
force-pushed
the
reconbot/management-api
branch
from
October 4, 2021 22:32
05cf0e8
to
db6f8e4
Compare
rebased again 🤞 |
reconbot
force-pushed
the
reconbot/management-api
branch
from
October 6, 2021 00:35
db6f8e4
to
111abde
Compare
- Fix tests that didn't expect a new path - Add api gateway websocket management to the management server
reconbot
force-pushed
the
reconbot/management-api
branch
from
November 4, 2021 02:47
b649c0c
to
476a95d
Compare
reconbot
force-pushed
the
reconbot/management-api
branch
4 times, most recently
from
November 11, 2021 03:50
a3bad09
to
1a59838
Compare
reconbot
force-pushed
the
reconbot/management-api
branch
from
November 11, 2021 03:53
1a59838
to
bab3a5b
Compare
ryanblock
reviewed
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works! I've tested this outside of our library.
TODO
arc/functions
feat: switch websockets to use ApiGatewayManagementApi in sandbox and production functions#499references
Working code for arc functions (only sandbox tested)
closes architect/architect#1204
Thank you for helping out! ✨
We really appreciate your commitment to improving Architect
To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:
master
npm it
from the repo root)readme.md
, help docs, inline docs & comments, etc.)changelog.md
Please also be sure to completed the CLA (if you haven't already).
Learn more about contributing to Architect here.
Thanks again!