Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.5] C2S Packet Registration Crashes Fabric Dedicated Servers #496

Closed
hammy275 opened this issue Apr 28, 2024 · 1 comment
Closed

[1.20.5] C2S Packet Registration Crashes Fabric Dedicated Servers #496

hammy275 opened this issue Apr 28, 2024 · 1 comment
Assignees
@Jab125
Labels
Fabric This issue is specific to the Fabric platform. priority: high This needs to be worked on and reviewed ASAP

Comments

@hammy275
Copy link

hammy275 commented Apr 28, 2024 •
edited
Loading

On Minecraft 1.20.5 Fabric, registering a C2S packet using Architectury API crashes the dedicated server, as it attempts to import the Minecraft class during registration. This happens in both dev and prod.

This can be reproduced by running the dedicated Fabric server on Architectury API's test mod, though it also happens with an implementation I wrote if you need a second reproduction.

In case it's relevant, I'm using Eclipse Termurin 21.0.3 as my JDK.
@shedaniel shedaniel added priority: high This needs to be worked on and reviewed ASAP Fabric This issue is specific to the Fabric platform. labels Apr 28, 2024
@hammy275 hammy275 mentioned this issue Apr 28, 2024
Closed
@hammy275
Copy link
Author

May be doing something wrong, but it seems this issue also occurs with S2C packets. This repo provides a minimal reproduction, along with a build.

@Jab125 Jab125 self-assigned this Apr 29, 2024
Jab125 added a commit to Jab125/architectury-api that referenced this issue Apr 29, 2024
@Jab125
Fix architectury#496
baf8ec7
@Jab125 Jab125 mentioned this issue Apr 29, 2024
Merged
shedaniel pushed a commit that referenced this issue Apr 29, 2024
@Jab125
Fix breakage in NeoForge 20.5.14, fix crash when registering packets …
02c89ba 
…on Fabric, fix players getting kicked when a S2C packet is sent to them. (#499)

* Fix #497

* Fix #496

* Fix #498

* Add test for #498

* Update architectury.mixins.json
@Jab125 Jab125 closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jab125 Jab125

Labels
Fabric This issue is specific to the Fabric platform. priority: high This needs to be worked on and reviewed ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hammy275 @shedaniel @Jab125