Skip output remapping for Mojang-mapped NeoForge projects #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a pretty noticeable improvement for Neo projects using Mojang mappings. For example, the
remapJartask for one of my Neo projects went from taking 5s to 1s. This still feels a little long, but any improvements there could probably be sent upstream as they wouldn't be arch/neo-specific.Ideally, we could also skip the remapping of incoming artifacts (without sacrificing things like stripping included jars). But in my opinion, that's not as big of a deal, since dependencies will be remapped much less often than your project output.
The implementation here clearly isn't optimal, but I think it's a reasonable/minimally-invasive stopgap with how NeoForge support currently works.