Make update-message escapping more consistent with send-message #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will check |
archive
added a commit
that referenced
this pull request
Mar 13, 2022
* Make update-message more consistent with send-message (#39) * Moved escaper code to shared util Co-authored-by: Krishna Rajendran <krishna@emptybox.org>
|
Thanks @blazzy! I have merged this into master and prepping for new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble with my update-messages not turning out like my send-message.
I made the escaping logic more consistent in a fork and am using that for now. This PR contains those changes. I didn't make any attempt to be DRY if that is a concern. I just copied and pasted the logic. Opening this up for reference and hoping some version will be incorporated upstream.
Thanks.
PS: I'd rather be using blocks, and I'm excited about that WIP PR to be able to update blocks.