Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Rights.csv metadata is not imported to METS file #305

Closed
peterVG opened this issue Oct 29, 2018 · 2 comments
Closed

Problem: Rights.csv metadata is not imported to METS file #305

peterVG opened this issue Oct 29, 2018 · 2 comments
Assignees
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone

Comments

@peterVG
Copy link
Collaborator

peterVG commented Oct 29, 2018

Expected behaviour
When including a rights.csv file in a transfer's /metadata directory using the correct CSV field mappings, the rights metadata will be included in the AIP METS file as RightsMD sections.

Current behaviour

The corresponding microservice ("Characterize and extract metadata/load rights") completes without an error but does report "Skipping duplicate basis/act combination at row 1, (row 2), (row 3), etc."

screen shot 2018-10-29 at 11 59 49

The AIP that is produced thereafter does not include any RightsMD sections.

NOTE: The rights import seems to work at least once on a fresh server/installation (without the "Skipping duplicate basis/acts combination" errors) but then the exact same sample data in a separate Transfer fails each time thereafter as described above.

Steps to reproduce

archivematica-sampledata-SampleTransfers-DemoTransfer is the one set of sample data that includes a rights.csv file which has been used for all Archivematica rights import testing to date. Conduct a transfer using this set of sample data and then search the corresponding METS file for a RightsMD section. The first time on a fresh installation completes successfully. e.g. see this screencap:

screen shot 2018-10-29 at 12 59 52

but any subsequent transfers will fail as described further above.

FYI: I rebuilt the AM18bionic.qa server specifically to test this. I ran two transfers seconds apart. The second one failed as reported.

Your environment (version of Archivematica, OS version, etc)

AM18bionic.qa, AM18xenial.qa, AM18Centos.qa


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@peterVG peterVG added the bug label Oct 29, 2018
@ross-spencer
Copy link
Contributor

This sounds a little related, it will be interesting to read more about the logic about why it is skipping: #130

@peterVG peterVG added this to the 1.8.0 milestone Oct 29, 2018
@sevein sevein added the Status: in progress Issue that is currently being worked on. label Oct 29, 2018
@sevein sevein self-assigned this Oct 29, 2018
@sevein sevein added Status: review The issue's code has been merged and is ready for testing/review. and removed Status: in progress Issue that is currently being worked on. labels Oct 30, 2018
@sevein sevein removed their assignment Oct 30, 2018
@sevein sevein added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. and removed Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. bug labels Oct 31, 2018
@sallain sallain self-assigned this Oct 31, 2018
@sallain
Copy link
Member

sallain commented Oct 31, 2018

This looks to be fixed! I ran a few transfers and the rights were properly applied each time.

@sallain sallain added Status: verified and removed Status: review The issue's code has been merged and is ready for testing/review. labels Oct 31, 2018
@sromkey sromkey closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

No branches or pull requests

5 participants