Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: PREMIS3 not being used consistently across AMAUAT, e.g. bind PIDs tests #777

Closed
ross-spencer opened this issue Jul 4, 2019 · 3 comments
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests Status: in progress Issue that is currently being worked on.

Comments

@ross-spencer
Copy link
Contributor

Expected behaviour

AMAUAT tests pass with qa/1.x

Current behaviour

Take this section of code here, where premis:is used as a prefix it won't match against PREMIS 3 namespaces as defined by this structure here. Where Bind PIDs relies on this section of code to pass, no identifiers will be discovered for file objects in the METS and so the test will fail.

Additional context

This is currently failing for the bind PIDs tests and so I will work on a fix for these. Other tests might fail so this ticket can serve as a quasi epic to capture those.

Additionally, there is a discussion to be had here about the expectation of the AMAUAT tests to pass against different versions of Archivematica where PREMIS 3 wasn't previously used. From a brief skim of the code, it looks like a little work will be needed to make it at least compatible with 1.9.2 again. I will open a separate feature discussion to discuss release processes for AMAUAT.


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@ross-spencer ross-spencer added Status: in progress Issue that is currently being worked on. triage-release-1.10 AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Jul 5, 2019
@sallain sallain added this to the 1.10.0 milestone Jul 15, 2019
@sromkey
Copy link
Contributor

sromkey commented Jul 19, 2019

Is this one ready for review?

@ross-spencer
Copy link
Contributor Author

ross-spencer commented Jul 19, 2019

Hi @sromkey. Nope. I should mark it as related to #778 as that will provide a second PR that covers other PREMIS3 uses in Archivematica that are being tested by AMAUAT. Review I would expect to be the tests we fix-up will pass.

@ross-spencer
Copy link
Contributor Author

PREMIS tests now passing for all working AMAUAT tests in the 1.10/0.15 release: https://github.com/artefactual-labs/archivematica-acceptance-tests/releases/tag/v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests Status: in progress Issue that is currently being worked on.
Projects
None yet
Development

No branches or pull requests

3 participants