Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: A release process is needed for AMAUAT tests #778

Closed
ross-spencer opened this issue Jul 4, 2019 · 3 comments
Closed

Problem: A release process is needed for AMAUAT tests #778

ross-spencer opened this issue Jul 4, 2019 · 3 comments
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests Request: discussion The path towards resolving the issue is unclear and opinion is sought from other community members. Status: review The issue's code has been merged and is ready for testing/review.

Comments

@ross-spencer
Copy link
Contributor

ross-spencer commented Jul 4, 2019

Please describe the problem you'd like to be solved.

I would like to make it easier to run the AMAUAT tests on different versions of Archivematica. Currently tests take a -D am_version=1.8 parameter, but historically, it is difficult to simply pass a version flag of the tests and expect them to pass where it relies on historical knowledge of releases, e.g. 1.10 will make breaking changes between PREMIS 2 and PREMIS 3 support.

Coding for this type of change in AMAUAT tests is also a challenge. It relies on being able to test simultaneously on n and n-1 versions of Archivematica and not all developers will have this set up. (if any?). It generates a lot of cognitive load.

Describe the solution you'd like to see implemented.

Create a release procedure for AMAUAT tests where:

  • A release cycle sees Archivematica qa/1.x released,
  • At that moment, a AMAUAT suite is released matching the AM version.

For future testing, e.g. a stable/1.x.x release, the release version of AMAUAT will be downloaded, and the Archivematica will be tested against that. If changes are required for stable/1.x.x then they will be incorporated into a new release branch of the AMAUAT tests.

We shouldn't have to worry about maintaining decision points in AMAUAT code where versions are used to direct logic.

Describe alternatives you've considered.

We can use the version flag discussed, but I'm not sure we have this working practically. Even with a version flag, then it might also be beneficial to:

  • Release AMAUAT per version of Archivematica.
  • Setup Jenkins to always have an n-1 backwards facing test that enables minor releases to be done more effectively.

Additional context


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@ross-spencer ross-spencer added the Request: discussion The path towards resolving the issue is unclear and opinion is sought from other community members. label Jul 4, 2019
@ross-spencer ross-spencer added the AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests label Jul 12, 2019
@sallain
Copy link
Member

sallain commented Jul 15, 2019

Consensus in Artefactual meeting was to proceed as Ross has suggested above, adding a release tag to the commit that was used to test the release. We will not try to maintain backwards compatibility. @ross-spencer can you add tagging procedure to release checklist?

@sallain sallain added the Status: in progress Issue that is currently being worked on. label Jul 15, 2019
@sallain sallain added this to the 1.10.0 milestone Jul 15, 2019
@ross-spencer
Copy link
Contributor Author

Related to #288

@ross-spencer
Copy link
Contributor Author

Branch and release tag created for 1.10 and 0.15 tests here: https://github.com/artefactual-labs/archivematica-acceptance-tests/releases/tag/v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests Request: discussion The path towards resolving the issue is unclear and opinion is sought from other community members. Status: review The issue's code has been merged and is ready for testing/review.
Projects
None yet
Development

No branches or pull requests

2 participants