Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: antivirus scanning can't be disabled #869

Closed
sevein opened this issue Aug 21, 2019 · 3 comments
Closed

Problem: antivirus scanning can't be disabled #869

sevein opened this issue Aug 21, 2019 · 3 comments
Labels
Bodleian Type: feature New functionality.
Milestone

Comments

@sevein
Copy link
Contributor

sevein commented Aug 21, 2019

Expected behaviour
The user should be able to disable antivirus scanning. A good start could be to have a single toggle in processing configuration. Further development could consider controlling it via FPR.

Current behaviour
There are five places in the workflow where antivirus scanning happens unavoidably.

  • Scan for viruses in metadata,
  • Scan for viruses in submission documentation,
  • Scan for viruses on extracted files,
  • Scan for viruses (right after you skip quarantine), and
  • Scan for viruses (right after email attachment extraction).

Related:

Your environment (version of Archivematica, OS version, etc)
All versions released to this day.


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Done:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@sromkey sromkey added the Type: feature New functionality. label Aug 21, 2019
@sromkey
Copy link
Contributor

sromkey commented Aug 21, 2019

I agree that just being able to turn all five places with one toggle is a good first iteration and in fact might cover the vast majority of use cases... lots of folks do virus scanning in some manner before content hits the digital preservation system and they won't be concerned about whether it's on/off for submission docs, etc.

@sevein
Copy link
Contributor Author

sevein commented Feb 24, 2021

Sebastian from Bodleian has been working on a solution adding new decision points on each antivirus scanning workflow link. In the Dashboard, a single decision point is shown but when enabled it translated into five pre-configured choices in the XML document. See https://github.com/artefactual/archivematica/pull/1687/files for more details.

@sromkey sromkey added this to the 1.13.0 milestone Feb 24, 2021
@replaceafill replaceafill added the Status: in progress Issue that is currently being worked on. label Feb 24, 2021
@sevein sevein self-assigned this Feb 24, 2021
@sevein sevein added Bodleian Status: review The issue's code has been merged and is ready for testing/review. and removed Status: in progress Issue that is currently being worked on. labels Mar 3, 2021
@sevein sevein removed their assignment Mar 9, 2021
@sromkey
Copy link
Contributor

sromkey commented Jun 18, 2021

Just tested- straight forward change from the user's point of view, and the METS looks correct too (e.g. no virus scanning events when turned off). Thank you @Slange-Mhath!

@sromkey sromkey closed this as completed Jun 18, 2021
@sromkey sromkey removed the Status: review The issue's code has been merged and is ready for testing/review. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bodleian Type: feature New functionality.
Projects
None yet
Development

No branches or pull requests

3 participants