core: define a normalized mode.

archiverjs · Apr 4, 2014 · 07792ad · 07792ad
1 parent 87f5311
commit 07792ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -117,7 +117,7 @@ Sets the entry comment.
 
 #### mode `number`
 
-Sets the entry permissions. (experimental)
+Sets the entry permissions. Defaults to octal 0755 (directory) or 0644 (file).
 
 ## Tar
 
@@ -143,7 +143,7 @@ Sets the entry date. This can be any valid date string or instance. Defaults to
 
 #### mode `number`
 
-Sets the entry permissions. Defaults to octal 0664.
+Sets the entry permissions. Defaults to octal 0755 (directory) or 0644 (file).
 
 ## Libraries
 

diff --git a/lib/modules/core/index.js b/lib/modules/core/index.js
@@ -45,6 +45,7 @@ Archiver.prototype._normalizeFileData = function(data) {
     type: 'file',
     name: null,
     date: null,
+    mode: null,
     sourcePath: null
   });
 
@@ -61,6 +62,12 @@ Archiver.prototype._normalizeFileData = function(data) {
     }
   }
 
+  if (typeof data.mode === 'number') {
+    data.mode &= 0777;
+  } else {
+    data.mode = isDir ? 0755 : 0644;
+  }
+
   data.date = util.dateify(data.date);
 
   return data;