Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move audit information fields (created_by and last_modified_by) out of keyword search for both public and staff interfaces) and into advanced search selections on staff interface only #1133

Merged
merged 1 commit into from Feb 22, 2018

Conversation

lmcglohon
Copy link
Contributor

No description provided.

…f keyword search for both public and staff interfaces) and into advanced search selections on staff interface only
Copy link
Contributor

@lorawoodford lorawoodford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new functionality of adding created by and modified by to advanced search works exactly as expected, however I don't see where this actually removes created by and modified by from keyword search. I am likely just reading the description incorrectly, but if we are really "moving these fields out of keyword search" to me that implies that that data shouldn't be in a keyword search. If I run a created by advanced search on some dummy data looking for "user123" I find records created by user123. But, if I type "user123" into the keyword search box, it still pulls back any records including user123. It's not really "moving" those fields, but adding those fields to advanced search (while also leaving them where they were initially in keyword search).

Otherwise, :+1

@lmcglohon
Copy link
Contributor Author

@lorawoodford hmmm... Maybe I missed something - as long as it was only in the created_by field, it shouldn't have shown up in the keyword search results. Let me work on it some more...

@lorawoodford
Copy link
Contributor

Ok, so ran this again and it looks to be running exactly as intended. I'm guessing I had truly reindexed my db the first time I tested this!

@lorawoodford lorawoodford merged commit 2756653 into master Feb 22, 2018
@lorawoodford lorawoodford deleted the advanced-search-audit-info branch February 22, 2018 20:35
@lmcglohon
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants