Lock i18n gem and bump sass-rails gem #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfitz
changed the title
This locks the indexer's use of the i18n, which was causing problems when running the test suite. Also bumps the sass-rails gem to get rid of the sprokets warning.
cdibella
added
the
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running some tests on public, I ran into an issue of the Rails app starting with a different version of i18n than was in the Gemfile.lock. Looks like the indexer's version got bumped up, so there was two versions of the gem in the GEM_HOME. I kinda remember there was an issue with the newer version, but I'm not sure? Frontend and Public Gemfiles all lock to a specific version, so I just did that to Indexer's as well.
Also bumped the version of sass-rails to get rid of the "DEPRECATION WARNING: Sprockets method
register_engineis deprecated."The Frontend still will get that warning because it's also using less-rails via the less-rails-bootstrap gem. This should probably be removed bc less-rails-bootstrap hasn't been updated in awhile and is made for Rails 3/4. Also, we don't really need it, since all the Bootstrap less files are also in the vendor directory. And we probably shouldn't be using both LESS and SASS ( especially since the Public UI is using SASS version of bootstrap ). But I know The Community is wanting to rewrite the Frontend UI, so....good luck!