Work In-Progress: Public UI refactor & tests #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the baseline for adding spec tests to the public UI. Adds a public:test and public:coverage ant task. Adds a spec_helper.rb and a basic WelcomeController test. Oh and adds the rails-rspec and simplecov gems.
This strips down the defined routes in the public UI in an attempt to figure out what's actually being used ( and needs testing ) and what's not ( and needs removing ). First pass is to remove most the POST definitions which seem redundant to the GET definitions.
This is a start to adding specs to the public UI by adding a controller spec for the AccessionsController.
cfitz
force-pushed
the
public-ui-refactor
branch
from
e1f5184
to
113f610
Compare
|
@cfitz Looks like a great start! Keep going! |
|
@cfitz I know this is a work in progress but I would like to merge it to the master branch so we can continue to build the PUI test corpus. Please let me know if that is OK with you. |
Move the pry-* gems to only be in the dev and test groups of the frontend.
|
@lmcglohon sure, if it looks good to you. I did notice one thing and moved the pry-* gems in the frontend into the dev/test groups. |
…rollers/welcome_controller_spec.rb @cfitz since frontend is a rails app, the welcome_controller_spec.rb should be in the spec/controllers directory.
cdibella
added
the
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the start of trying to add some test coverage to the Public UI.
It's a work in progress and this PR is just to provide a reference.
Adds a public:test ( and public:coverage ) that starts backend and solr then runs the rspec suite.
Any thoughts/suggestions/help is much appreciated.