ANW-451 #1205
ANW-451 #1205
Conversation
|
Review note: The commit "MODS Export: export dates as per spec" was refactored and superseded by "MODS Export: Updates to date processing: set point, keyDate, and enco…" |
|
Just rebased with latest master as of 4/13. |
| @@ -35,7 +35,7 @@ def serialize_mods_inner(mods, xml) | |||
|
|
|||
|
|
|||
| xml.language { | |||
| xml.languageTerm(:type => 'code') { | |||
There was a problem hiding this comment.
@avatar382 @cdibella Do we need to have both the language code and language term exported in two different XML tags? As a reference, I am looking at lines 19-27 in the spreadsheet attached to ANW-451.
There was a problem hiding this comment.
Yes, the intent is to have two different XML tags - one with a type "text" and the other with a type "code"
backend/app/exporters/models/mods.rb
Outdated
| @@ -171,7 +171,6 @@ def handle_notes(notes) | |||
| def handle_extent(extents) | |||
| extents.each do |ext| | |||
| e = ext['number'] | |||
| e << " (#{ext['portion']})" if ext['portion'] | |||
There was a problem hiding this comment.
@avatar382 @cdibella I may have missed a conversation, but not seeing the removal of this from the extents string described in the spreadsheet.
| @@ -81,7 +81,7 @@ def serialize_mods_inner(mods, xml) | |||
| xml.temporal term | |||
| when 'uniform_title' | |||
| xml.titleInfo term | |||
| when 'genre_form', 'style_period' | |||
| when 'genre_form', 'style_period', 'technique' | |||
There was a problem hiding this comment.
@avatar382 @cdibella From spreadsheet line 231, should this also include 'function'?
There was a problem hiding this comment.
Yes, function should be in there too - all three map to the mods tag genre.
| content = ASpaceExport::Utils.extract_note_text(note) | ||
| mods_note = case note['type'] | ||
| when 'physdesc' | ||
| new_mods_note('note', |
There was a problem hiding this comment.
@avatar382 @cdibella From note on line 72 of spreadsheet, shouldn't both the physdesc and dimensions notes be wrapped in a physicalDescription tag? If so, I believe that is the last (5th) input parameter for the new_mods_note method.
There was a problem hiding this comment.
yes, is the wrapper tag for both of these things
There was a problem hiding this comment.
my tag disappeared, at least on the web page, but yup, physicalDescription is the wrapper
|
I've fixed the language code and genre fixes. Looking at the physicalDescription one, the note tags are wrapped in a physicalDescription tag, but not individually. Here's some sample output: Does this look right? |
typeOfResource tag
languageTerm tag to reflect contents
physicalDescription/extents
…ding attrys correctly
agents if provided
Delete unpublished digital object added in this pull request.
|
@avatar382 @cdibella I think having everything wrapped inside one physical description is correct - Christine? |
|
Yes, one physical description tag, with multiple notes (depending on what’s there) inside
|
Fix to test
Also includes fixes for:
ANW-175
ANW-176