ANW-673 #1212
Merged
ANW-673 #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avatar382 This looks perfect but can you add a test that ensures an empty 044 isn't exported when there isn't a country field in the repository record? |
…epo, 044 tag should not exist and 008 should have 'xx' in country code section
avatar382
changed the title
|
Just added tests for the opposite case. I had some trouble last week with the opposite test case, I couldn't get repo set up correctly in two states (country and no country), I was seeing strange failures in other tests. Seems fine now that I put the test in it's own describe block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.